Skip to content

test(NODE-3710): sync max srv hosts tests #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2021
Merged

test(NODE-3710): sync max srv hosts tests #3015

merged 3 commits into from
Oct 26, 2021

Conversation

durran
Copy link
Member

@durran durran commented Oct 24, 2021

Description

Syncs tests for limiting the number of MongoDB hosts a SRV record can return.

What is changing?

Adds the initial DNS seed discovery tests to support the new feature.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Syncing tests in order to implement the feature.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests

@durran durran requested a review from dariakp October 25, 2021 14:25
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 25, 2021
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the spec repo, these tests are all in subfolders, e.g., load-balanced, replica-set. I think keeping them in the same directories instead of flattening would help ensure we actually pull in all the changes and keep things up to date in the future. In the spec commit, there are 48 changed files, subtracting the 4 actual spec modifications, that's 44 files, 42 of which are yml/json, but I only see 32 in this PR, so I think we are missing some changes.

Also, I think it would be worth pulling in https://jira.mongodb.org/browse/NODE-3696
these spec changes into the PR, so that we are working off the correct set of expectations for the uri-options tests from the get-go (see this spec commit)

@durran
Copy link
Member Author

durran commented Oct 26, 2021

Updated uri options tests to NODE-3696, and changed the directory structure to match the spec tests and resynced.

@durran durran requested a review from dariakp October 26, 2021 14:20
@dariakp dariakp merged commit 970e2c3 into main Oct 26, 2021
@dariakp dariakp deleted the NODE-3710 branch October 26, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants