test(NODE-3709): sync / crud spec tests #3013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
dariakp
requested changes
Oct 25, 2021
There was a problem hiding this comment.
I think we should include these changes: https://jira.mongodb.org/browse/NODE-3694
in this PR, so that we're working off the most accurate representation of the tests for the implementation (it's just setting a minServerVersion, see spec commit)
|
I've updated to include NODE-3694 now. |
dariakp
approved these changes
Oct 26, 2021
dariakp
pushed a commit
that referenced
this pull request
Nov 2, 2021
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncs the CRUD spec tests for DRIVERS-823 (Support $out/$merge on secondaries).
What is changing?
Updates the new spec tests per the spec change, failing new tests are skipped until NODE-3083 is implemented.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Synced tests are required to implement NODE-3083
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>