Skip to content

chore(NODE-3186): ensure aws tests are run [PORT 4.0] #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 6, 2021

In addition to the port from 3.6 there was a small fix to be made in the AWS auth that checks empty strings as falsey instead of just omitted values. #2776

@nbbeeken nbbeeken requested review from emadum and durran April 8, 2021 14:25
@nbbeeken nbbeeken marked this pull request as ready for review April 8, 2021 14:25
@nbbeeken nbbeeken merged commit 2e3335b into 4.0 Apr 9, 2021
@nbbeeken nbbeeken deleted the NODE-3186/ensure-aws-tests-run/4.0 branch April 9, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants