chore: capture more informative stack trace in session leak checker #2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we migrated to acquiring a server session lazily the stack traces for the sesson leak checker haven't been very helpful. This patch records the trace from the call to `Topology#startSession` in order to provide a more high quality trace. NODE-2880
nbbeeken
approved these changes
Nov 12, 2020
HanaPearlman
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we migrated to acquiring a server session lazily the stack traces for the sesson leak checker haven't been very helpful. This patch records the trace from the call to
Topology#startSessionin order to provide a more high quality trace.NODE-2880