chore(ci): add xunit output to evergreen config #2596
Conversation
emadum
changed the title
| @@ -207,7 +207,6 @@ functions: | |||
| params: | |||
| working_dir: src | |||
| script: | | |||
| ${PREPARE_SHELL} | |||
There was a problem hiding this comment.
is there a reason this was removed?
There was a problem hiding this comment.
I'm guessing it was a change that was made directly to the config.yml and not to config.yml.in, so it was lost when regenerating the file. I can take a closer look.
| @@ -103,7 +103,7 @@ functions: | |||
| params: | |||
| file: mo-expansion.yml | |||
|
|
|||
| bootstrap mongohoused: | |||
| "bootstrap mongohoused": | |||
There was a problem hiding this comment.
Is it possible to make this change without all the whitespace (quotation mark) changes in this file?
There was a problem hiding this comment.
Yeah, I just added quotes to a few that were missing them for consistency - it makes the titles show up in a different color on syntax highlighting, which I thought was nice, but I can revert that.
There was a problem hiding this comment.
@mbroadst Just confirming, should I revert the quotation mark changes I made to improve consistency?
There was a problem hiding this comment.
No that's fine, I just wondered what was going on
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "require": "ts-node/register" | |||
| "require": "ts-node/register", | |||
| "reporter": "spec-xunit-file" | |||
There was a problem hiding this comment.
hm this is specified in the script above, can we reduce it to one place?
There was a problem hiding this comment.
I didn't add --reporter spec-xunit-file to the npm scripts that use this file via the --config option in order to reduce verbosity. I can expand it out into the package scripts if desired.
There was a problem hiding this comment.
Can't you add this same setting to .mocharc.json?
There was a problem hiding this comment.
My logs filter PR #2605 undoes the work here in favor of an in house xml reporter.
There's a few features that this xml reporter lacks:
- it doesn't capture stdout and stderr (meaning you can see deprecation warnings, for tests that care about that, or run special patches with print statements for debugging)
- it escapes the text inside the CDATA blocks which is unnecessary, it makes reading the errors a bit strange
- the timestamps aren't an ISO format
- it emits one testsuite for all mocha tests, it doesn't change much about the display but its logically inconsistent with our test organization
I'm still LGTM-ing this though because all this isn't to say we shouldn't consider merging this, my PR is larger, and comes with more mental overhead, if we want this test reporting feature right now (which it is really nice to have) and end up accepting my PR later I still think that that could be worth our while.
| @@ -1,3 +1,4 @@ | |||
| { | |||
| "require": "ts-node/register" | |||
| "require": "ts-node/register", | |||
| "reporter": "spec-xunit-file" | |||
There was a problem hiding this comment.
Can't you add this same setting to .mocharc.json?
Description
check:package scripts, via thespec-xunit-filereporter. This reporter is useful because it continues to send the output of the defaultspecreporter to stdout, while also generating an XML file with the xunit results.attach.xunit_resultsin aposthookWhat changed?
Are there any files to ignore?