test: Update connection-monitoring-and-pooling specs #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
approved these changes
Sep 29, 2020
mbroadst
approved these changes
Sep 30, 2020
emadum
approved these changes
Sep 30, 2020
Update connection-monitoring-and-pooling tests ensuring ConnectionCreated proceed ConnectionReady events NODE-2804
nbbeeken
force-pushed
the
NODE-2804/create-before-ready-event
branch
from
a5f5d49 to
b014976
Compare
@reggi PTAL at the update script (even better would be if you could give it a whirl for me). Should be able to support a specific git hash as an optional second argument. |
reggi
reviewed
Oct 1, 2020
etc/update-spec-tests.sh
Outdated
| curl -sL "https://github.com/mongodb/specifications/archive/master.zip" -o "$tmpdir/specs.zip" | ||
| unzip -d "$tmpdir" "$tmpdir/specs.zip" > /dev/null | ||
| mkdir -p "$spec_root/$1" | ||
| rsync -ah "$tmpdir/specifications-master/source/$1/tests/" "$spec_root/$1" --delete |
There was a problem hiding this comment.
Suggested change
| rsync -ah "$tmpdir/specifications-master/source/$1/tests/" "$spec_root/$1" --delete | |
| rsync -ah --exclude '*.rst' "$tmpdir/specifications-master/source/$1/tests/" "$spec_root/$1" --delete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connection-monitoring-and-pooling tests
ensuring ConnectionCreated proceed ConnectionReady events
NODE-2804
Note to reviewers
I have a spec sync script I suggest we bring in here, if anyone has a hesitation we can drop that.
There were a few formatting issues that made it to 3.6, the fixes are in here.