Skip to content

RUST-2167 Deprecate hedged reads #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ take_mut = "0.2.2"
thiserror = "1.0.24"
tokio-openssl = { version = "0.6.3", optional = true }
tracing = { version = "0.1.36", optional = true }
typed-builder = "0.10.0"
typed-builder = "0.20.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bump was necessary to pull in idanarye/rust-typed-builder#88

webpki-roots = "0.26"
zstd = { version = "0.11.2", optional = true }
macro_magic = "0.5.1"
Expand Down
13 changes: 11 additions & 2 deletions src/selection_criteria.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ impl std::fmt::Display for ReadPreference {
if let Some(ref max_staleness) = options.max_staleness {
write!(f, ", Max Staleness: {:?}", max_staleness)?;
}
#[allow(deprecated)]
if let Some(ref hedge) = options.hedge {
write!(f, ", Hedge: {}", hedge.enabled)?;
}
Expand Down Expand Up @@ -215,6 +216,7 @@ impl Serialize for ReadPreference {
}

/// Specifies read preference options for non-primary read preferences.
#[allow(deprecated)]
#[serde_with::skip_serializing_none]
#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, TypedBuilder)]
#[builder(field_defaults(default, setter(into)))]
Expand All @@ -241,15 +243,21 @@ pub struct ReadPreferenceOptions {

/// Specifies hedging behavior for reads. These options only apply to sharded clusters on
/// servers that are at least version 4.4. Note that hedged reads are automatically enabled for
/// read preference mode "nearest".
/// read preference mode "nearest" on server versions less than 8.0.
///
/// See the [MongoDB docs](https://www.mongodb.com/docs/manual/core/read-preference-hedge-option/) for more details.
#[deprecated(
note = "hedged reads are deprecated as of MongoDB 8.0 and will be removed in a future \
server version"
)]
pub hedge: Option<HedgedReadOptions>,
}

impl ReadPreferenceOptions {
pub(crate) fn is_default(&self) -> bool {
self.hedge.is_none()
#[allow(deprecated)]
let hedge = self.hedge.is_some();
!hedge
&& self.max_staleness.is_none()
&& self
.tag_sets
Expand Down Expand Up @@ -354,6 +362,7 @@ mod test {

#[test]
fn hedged_read_included_in_document() {
#[allow(deprecated)]
let options = Some(
ReadPreferenceOptions::builder()
.hedge(HedgedReadOptions { enabled: true })
Expand Down
1 change: 1 addition & 0 deletions src/test/spec/trace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ fn selection_criteria_tracing_representation() {
"ReadPreference { Mode: PrimaryPreferred, Max Staleness: 200ms }"
);

#[allow(deprecated)]
let opts_with_hedge = Some(
ReadPreferenceOptions::builder()
.hedge(HedgedReadOptions::builder().enabled(true).build())
Expand Down
4 changes: 3 additions & 1 deletion src/test/spec/unified_runner/test_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,10 @@ fn deserialize_selection_criteria() {
options: Some(options),
} => {
assert_eq!(options.max_staleness, Some(Duration::from_secs(100)));
#[allow(deprecated)]
let hedge = options.hedge;
assert_eq!(
options.hedge,
hedge,
Some(HedgedReadOptions::builder().enabled(true).build())
);
}
Expand Down