RUST-1934 Publish internal macros as their own crate #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
May 21, 2024
| @@ -74,45 +74,53 @@ struct Args { | |||
| } | |||
|
|
|||
| fn main() { | |||
| let zero = std::env::current_exe().unwrap(); | |||
There was a problem hiding this comment.
This is unrelated but I got annoyed at having to prepend "../.." to every path.
kevinAlbs
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1934
Rust requires that macros be in a crate distinct from where they're used, and cargo doesn't allow crates with internal sub-crates to be published, so published as its own crate it shall be :(
My aim here is for this to be as invisible as possible; the
mongodb-internal-macroscrate will always have the same version number as the mainmongodbcrate, and will be published/signed/attested by the same scripts, so unless something goes wrong we won't ever have to think about it.