RUST-1663: Implement and enable reauthentication for OIDC #1044
Conversation
| self | ||
| ), | ||
| } | ||
| .into()), |
There was a problem hiding this comment.
It doesn't seem that cfg is allowed within a pattern, unfortunately.
| // If the error is a reauthentication required error, we reauthenticate and | ||
| // retry the operation. | ||
| if err.is_reauthentication_required() { | ||
| let credential = self.inner.options.credential.as_ref().ok_or( |
There was a problem hiding this comment.
both of these errors should be impossible under the current sever spec, but this does future proof us.
| @@ -1,14 +1,27 @@ | |||
| use crate::{ | |||
There was a problem hiding this comment.
I decided to correct these two tests in this PR as a start on the rest of the prose tests. These tests need to assert the number of times the callback is called.... getting a shared Arc into closures with async blocks is nearly impossible. There does not appear to be a way to do it without the top level function here.
There was a problem hiding this comment.
The ownership here is gnarly, but it can be made to work: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=437cdfd395260f80a01ddce572d97d52
The trick is that you need to clone the Arc twice: once to give an owned value to the Fn, and a second time within that callback to give an owned value to the Future. That second clone is needed because the outer callback can be called multiple times, and each time it has to produce a future that owns the value, so each time it's called it has to re-clone the Arc.
This can be boiled down a little bit to remove the async aspect, which makes it easier to see what's going on: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=5f8a27ba1ae567f9ba337489d6a49a40
This is also why the distinction between Fn and FnOnce exists; if the Rust compiler knows that the closure can be called at most once, it's fine with transferring ownership from the closure to its return value: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=44aeb2634aa8e87c43e86ea349106f6a
There was a problem hiding this comment.
Interesting. I thought I tried cloning twice and that was what was really shocking to me. I must be misremembering
This ended up much easier than I expected, thanks to how well the rust driver is architected