RUBY-3284 Enable max_connecting client option #2739
Conversation
lib/mongo/server/connection_pool.rb
Outdated
| @@ -36,6 +36,10 @@ class ConnectionPool | |||
| # @since 2.9.0 | |||
| DEFAULT_MIN_SIZE = 0.freeze | |||
|
|
|||
| # The default maximum number of connections that can be connecting at | |||
| # any given time. | |||
| DEFAULT_MAX_CONNECTING = 2.freeze | |||
There was a problem hiding this comment.
Freezing an immutable constant doesn't really do anything, does it? My understanding is that the primary purpose of freezing constants is to prevent them from being modified in place. Is there another reason for freezing numbers (which are already immutable)?
spec/mongo/uri/srv_protocol_spec.rb
Outdated
| let(:max_connecting) { 10 } | ||
| let(:options) { "maxConnecting=#{max_connecting}" } | ||
|
|
||
| it 'sets the max pool size option' do |
There was a problem hiding this comment.
Should this read 'sets the max connecting option'?
lib/mongo/client.rb
Outdated
| # This option should be increased if there are many threads that share | ||
| # the same client and the application is experiencing timeouts | ||
| # while waiting for connections to be established. | ||
| # selecting a server for an operation. The default is 100. |
There was a problem hiding this comment.
"... The default is 100"
Is that a copy/paste artifact?
There was a problem hiding this comment.
It is indeed, good catch! Thank you, fixed.
| # Exception that is raised when trying to create a client with an invalid | ||
| # max_connecting option. | ||
| # | ||
| # @since 2.4.2 |
There was a problem hiding this comment.
Should this be 2.19.0 (not 2.4.2)?
There was a problem hiding this comment.
This is a copy/paste artifact, too. We do not use @SInCE tag at all now. Removed, thank you.
No description provided.