RUBY-3262 enable QEv2 tests on Serverless #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just removing a bandaid I added a few weeks ago to work around this very issue
comandeo
previously requested changes
Jun 13, 2023
There was a problem hiding this comment.
We should also add these specs to the set we run on serverless -- https://github.com/mongodb/mongo-ruby-driver/blob/master/.evergreen/run-tests-serverless.sh#L95
|
Oh, good catch @comandeo! I totally missed that the serverless tests were run specifically. I'll get that updated. |
also some incidental cleanup of the version parsing code, which turned out to be unnecessary
jamis
dismissed
comandeo’s stale review
Added the specs to the serverless configuration
comandeo
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs the fle2v2-* specs with the commit indicated in the ticket. We do not appear to be skipping serverless anywhere in the prose tests, so nothing else needed to be updated.
This also addresses RUBY-3270, effectively just removing a bandaid I added several weeks ago to
spec/support/utils.rbto removenilvalues from the expected values.ref: https://jira.mongodb.org/browse/RUBY-3262, https://jira.mongodb.org/browse/RUBY-3270