RUBY-3252 Show user friendly error if no ffi #2730
Conversation
|
Changes and error message lgtm |
|
|
||
| describe Mongo::Crypt do | ||
| describe '.validate_ffi!' do | ||
| context 'when ffi is available' do |
There was a problem hiding this comment.
Should there be something here to test for the cases where FFI is not installed? Or skip when it isn't?
There was a problem hiding this comment.
I couldn't come up with a reasonable complex solution for testing this case. We have gem 'ffi' in our standard set of dependencies for testing. So, we would need a dedicated configuration just to test this feature; I think this is an overhead.
There was a problem hiding this comment.
Ah! That makes sense. I'll trust that you've thought about this a lot more than I have. :) Thanks for the explanation. Maybe a comment in that spec, explaining the situation, would be helpful to future-us?
|
|
||
| describe Mongo::Crypt do | ||
| describe '.validate_ffi!' do | ||
| context 'when ffi is available' do |
There was a problem hiding this comment.
Ah! That makes sense. I'll trust that you've thought about this a lot more than I have. :) Thanks for the explanation. Maybe a comment in that spec, explaining the situation, would be helpful to future-us?
* RUBY-3252 Show user friendly error if no ffi * Cleanup * Remove one test * Add comment explaining why test is omited
https://jira.mongodb.org/browse/RUBY-3252