RUBY-3152 Collect FaaS platform info in handshake #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo
approved these changes
Jun 1, 2023
jamis
added a commit
that referenced
this pull request
Jun 1, 2023
* add environment detection logic * add environment info, and updated truncation logic * rubocop pass for new files * prose tests from handshake spec * updated truncation logic, and AWS detection logic * minor cleanups * linter fixes for AppMetadata * fix the low-hanging linter fruit * linting updates * linting updates * fix missed linter complaint * fix broken tests caused by refactoring for linter
jamis
added a commit
to jamis/mongo-ruby-driver
that referenced
this pull request
Jun 7, 2023
* add environment detection logic * add environment info, and updated truncation logic * prose tests from handshake spec * updated truncation logic, and AWS detection logic * minor cleanups
jamis
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses DRIVERS-2209 and DRIVERS-2623. It adds a new (optional)
:envkey to the client document in the handshake, describing the current FaaS environment (if any). This PR also updates the logic to truncate the client document, to keep it under the maximum document size of 512 bytes.(Another PR is forthcoming to update the touched files to satisfy Rubocop.)
Ref: https://jira.mongodb.org/browse/RUBY-3152