Skip to content

RUBY-3156 Error if RewrapManyDataKey is called with masterKey and without provider #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2023
Merged

RUBY-3156 Error if RewrapManyDataKey is called with masterKey and without provider #2720

merged 4 commits into from
May 31, 2023

Conversation

jamis
Copy link
Contributor

@jamis jamis commented May 26, 2023

Implements a test to make sure that if #rewrap_many_data_key is called with a :master_key and without a :provider, that an exception is raised. It was also necessary to implement a check to the same effect.

@jamis jamis requested a review from comandeo May 26, 2023 20:17
@jamis jamis mentioned this pull request May 26, 2023
Merged
@jamis jamis merged commit 6c2c84d into mongodb:master May 31, 2023
@jamis jamis deleted the 3156-rewrap-many-data-key-without-provider branch May 31, 2023 14:31
jamis added a commit that referenced this pull request Jun 1, 2023
@jamis
RUBY-3156 Linter appeasement for #2720 (#2721)
4c79339 
* RUBY 3156 enforce that masterKey requires provider

* linter appeasement

* reference the correct variable

* rubocop work is being done in a separate branch

* remove the rubocop:todo for this file

* remove merge artifact

* merge artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamis @comandeo