RUBY-2495 rework the check_out method #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilshweky
commented
Nov 21, 2022
| # | ||
| # @param [ Array<Connection> ] connections A list of connections. | ||
| # @param [ Object ] service_id The service id. | ||
| def close_connections(connections, service_id) | ||
| def close_available_connections(service_id) |
There was a problem hiding this comment.
Changed this to explicitly close available connections because it was only being used on available connections, and I don't want it to be used for other connections in the future, since if it is used on pending or checked_out connections, the size_cv has to be signaled as well.
neilshweky
commented
Nov 23, 2022
comandeo
approved these changes
Nov 24, 2022
| @@ -1181,6 +1047,239 @@ def clear_pending_connections | |||
| @pending_connections.delete(connection) | |||
| end | |||
| end | |||
|
|
|||
| # The lock should be acquired when calling this method. | |||
There was a problem hiding this comment.
do you think it would be a good idea to raise if the lock is not owned in some of these methods?
comandeo
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.