RUBY-3117 investigate and fix test failures as a result of removing validating_keys #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilshweky
force-pushed
the
RUBY-3117
branch
from
852ec62 to
71b4e22
Compare
p-mongo
approved these changes
Sep 13, 2022
Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com>
jamis
pushed a commit
to jamis/mongo-ruby-driver
that referenced
this pull request
Jun 13, 2023
…alidating_keys (mongodb#2620) * RUBY-3117 investigate and fix test failures as a result of removing validating_keys * RUBY-3117 remove all references to BSON::Config.validating_keys? * Update gemfiles/bson_master.gemfile Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com> Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com>
jamis
added a commit
that referenced
this pull request
Jul 3, 2023
* RUBY-3232 Switch to supported build hosts (#2712) * Bump to latest toolchain and clean up specs to use consistent (and modern) build hosts * fix config validation errors * don't try to run ruby 2.7 on ubuntu2204 * bump submodule to get updated toolchain version * rhel84 -> rhel80 * keep tweaking * add "require_solo" helper * for testing: pointing spec/shared at my own branch * update spec/shared again to fix typo * bump spec/shared version again to prevent apt-get install from prompting * make sure cmake is installed for FLE runs * don't test on 3.2 yet (broken tests) * make sure we check for cmake BEFORE the bundle is installed * use MDB 5.x for testing certain auth mechanisms this is because run-tests.sh uses `mongo` to configure the MDB instance for certain auth mechanisms, which isn't shipped in MDB 6+. * try building the native extension for mongo_kerberos * remove jruby-9.4 for now to see if things pass any better with 9.3 * bump spec/shared to get updated server registry (for aarch64 versions) * update serverless to use rhel80 * move the install_cmake function to spec/shared, and make sure it gets called in run-tests-gcp * don't run zstd tests on jruby (no support) * bump spec/shared to get updated target arch selection * replace jruby 9.4 with 9.3 in sample_rubies list * bump spec/shared again * make sure kerberos stuff doesn't get confused by the BUNDLE_GEMFILE variable * don't test jruby on arm for now * don't assume x86_64 architecture * fix invalid config * jruby-9.3 isn't being built for ubuntu/debian :/ * need to build the bundle for the kerberos gem before compiling it * bump spec/shared to latest from my branch * jruby-9.3 is being built as a recent ruby now * don't include ruby-3.2 in supported rubies (yet) * rebuild config.yml * bump spec/shared * leaving out debian11 for now; we have ubuntu2204, which is closely related * the file is /etc/os-release, not /etc/os_release * remove jruby from FLE tests * comment out the failing tests (and reference the corresponding Jira tickets) this will at least let us get this "build hosts" effort sorted * forgot to comment out 'latest' * cmake is only needed if the helper is being installed Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> * bump spec/shared --------- Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> * more cleanup from the merge * more merge confusion * update all of the .evergreen folder * bump ruby versions in README * RUBY-3216 Skip failing view spec (#2701) * remove azure/gcp tests taken from master * no sdam_unified_spec in 2.18-stable * RUBY-3275 Update Atlas certificate (#2735) * RUBY-3275 Update Atlas certificate * Add a custom error message * bump drivers-evergreen-tools to try and make GH actions pass * need to update the GH actions definition, too * nix the rspec-mocks-diag gem so we can run more recent rspec all this to fix a ruby 3.2 incompatibility * disambiguate options hash vs keyword args * handle expection with kwargs * RUBY-3117 investigate and fix test failures as a result of removing validating_keys (#2620) * RUBY-3117 investigate and fix test failures as a result of removing validating_keys * RUBY-3117 remove all references to BSON::Config.validating_keys? * Update gemfiles/bson_master.gemfile Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com> Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com> * trying to get the web identity spec to pass * no web-identity tests for 2.18-stable * add an explicit dependency on nokogiri aws wants an XML parser * Let's not test 2.18-stable against MDB 7+ * remove unsupported configurations for 2.18-stable --------- Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> Co-authored-by: Neil Shweky <neilshweky@gmail.com> Co-authored-by: Oleg Pudeyev <39304720+p-mongo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.