Skip to content

PYTHON-2544 Do not check error messages when an error code is present #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

PYTHON-2544 Do not check error messages when an error code is present #574

merged 1 commit into from
Mar 4, 2021

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Mar 3, 2021 •
edited
Loading

Add 10058 as a "not master" error code to account for MongoDB<=3.2 errors.

This change implements: mongodb/specifications#920

@ShaneHarvey
PYTHON-2544 Do not check error messages when an error code is present
b0f867c 
Add 10058 as a "not master" error code to account for MongoDB<=3.2 errors.
@ShaneHarvey ShaneHarvey marked this pull request as ready for review March 4, 2021 00:31
prashantmital
prashantmital approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am loving the close correspondence between these code changes and the pseudocode included in the spec. LGTM

@ShaneHarvey ShaneHarvey merged commit de7c7b8 into mongodb:master Mar 4, 2021
ShaneHarvey added a commit that referenced this pull request Mar 4, 2021
@ShaneHarvey
PYTHON-2544 Do not check error messages when an error code is present (…
b10921e 
…#574)

Add 10058 as a "not master" error code to account for MongoDB<=3.2 errors.

(cherry picked from commit de7c7b8)
@ShaneHarvey ShaneHarvey deleted the PYTHON-2544 branch March 4, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantmital prashantmital prashantmital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneHarvey @prashantmital