PYTHON-2404 Update CSFLE spec tests for KMS providers 'azure' and 'gcp' #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Nov 3, 2020
test/test_encryption.py
Outdated
| def run_test(self, provider_name): | ||
| # Create data key. | ||
| master_key = self.MASTER_KEYS[provider_name] | ||
| if master_key is not None: |
There was a problem hiding this comment.
Aren't both calls to create_data_key equivalent here since master_key=None is valid?
| kms_providers = {'aws': AWS_CREDS, | ||
| 'azure': AZURE_CREDS, | ||
| 'gcp': GCP_CREDS} | ||
| self.client_encryption = ClientEncryption( |
There was a problem hiding this comment.
This overwrites the cls.client_encryption that's created in setUpClass. Suggest renaming or moving this logic to setUpClass if possible.
There was a problem hiding this comment.
The prose tests explicitly ask for recreating this object for every test so I have simply removed this from setUpClass - it had been left there in error.
|
Interesting, this is an example of a transient network error to azure's KMS (timed out after 10 seconds): |
|
Interesting to be able to observe the timeout on Azure! As per the spec, it doesn't seem like we should be adding any custom handling for that kind of an error so I suppose there is nothing to do there? I am also seeing the following in the test logs: I will open a JIRA ticket to track this. |
ShaneHarvey
reviewed
Nov 4, 2020
| @classmethod | ||
| def tearDownClass(cls): | ||
| cls.client.close() | ||
| cls.vault.drop() |
There was a problem hiding this comment.
These two lines should be swapped. Dropping the vault collection reopens the client we just closed.
This will fixed the unclosed client issue:
[2020/11/04 00:08:54.758] Topology <Topology <TopologyDescription id: 5fa1f0698ad53cb215fa7405, topology_type: ReplicaSetWithPrimary, servers: [<ServerDescription ('localhost', 27017) server_type: RSPrimary, rtt: 0.000538420648610058>, <ServerDescription ('localhost', 27018) server_type: RSSecondary, rtt: 0.001056252019849808>, <ServerDescription ('localhost', 27019) server_type: RSArbiter, rtt: 0.0009123198919968762>]>> has THREADS RUNNING: [<PeriodicExecutor(name=pymongo_server_monitor_thread) object at 0x7ff450e41a90>, <PeriodicExecutor(name=pymongo_server_rtt_thread) object at 0x7ff450e41a50>, <PeriodicExecutor(name=pymongo_server_monitor_thread) object at 0x7ff450bfb350>, <PeriodicExecutor(name=pymongo_server_rtt_thread) object at 0x7ff450bfb250>, <PeriodicExecutor(name=pymongo_server_monitor_thread) object at 0x7ff450bfbc10>, <PeriodicExecutor(name=pymongo_server_rtt_thread) object at 0x7ff4524dbbd0>], created at:
...
[2020/11/04 00:08:54.758] File "/data/mci/1d06ce731bf44d878db71873b3380fd4/src/test/test_encryption.py", line 630, in setUpClass
[2020/11/04 00:08:54.758] cls.client = rs_or_single_client(event_listeners=[cls.listener])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.