Skip to content

PYTHON-2371 Add Azure and GCP support for CSFLE #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2020
Merged

PYTHON-2371 Add Azure and GCP support for CSFLE #506

merged 4 commits into from
Oct 29, 2020

Conversation

prashantmital
Copy link
Contributor

ShaneHarvey
ShaneHarvey reviewed Oct 17, 2020
View reviewed changes
@prashantmital
Copy link
Contributor Author

Ready for another look @ShaneHarvey

@prashantmital prashantmital changed the title PYTHON-2371 Add support for Azure and GCP KMS PYTHON-2371 Add Azure and GCP support for CSFLE Oct 20, 2020
ShaneHarvey
ShaneHarvey requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document the new gcp and azure keys in ClientEncryption and AutoEncryptionOpts?

@prashantmital prashantmital force-pushed the PYTHON-2371/new-fle-keystores branch from 9de58b6 to f9bcabb Compare October 22, 2020 17:45
ShaneHarvey
ShaneHarvey reviewed Oct 22, 2020
View reviewed changes
ShaneHarvey
ShaneHarvey reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the "master_key" docs for ClientEncryption.create_data_key?

@prashantmital
Copy link
Contributor Author

@ShaneHarvey updated.

ShaneHarvey
ShaneHarvey reviewed Oct 23, 2020
View reviewed changes
@ShaneHarvey
Copy link
Member

I also opened https://jira.mongodb.org/browse/PYTHON-2405 to fix the AttributeError: function/symbol 'mongocrypt_setopt_kms_providers' not found in library 'libmongocrypt.so.0': test failures.

@prashantmital
Copy link
Contributor Author

Finally figured out why the tests weren't running - I wasn't exporting the environment variable names correctly.

@ShaneHarvey
Copy link
Member

Can you schedule the latest patch to run python 2.7-3.6 to make sure the new tests work there too?

@prashantmital prashantmital mentioned this pull request Oct 27, 2020
Merged
ShaneHarvey
ShaneHarvey requested changes Oct 28, 2020
View reviewed changes
ShaneHarvey
ShaneHarvey requested changes Oct 28, 2020
View reviewed changes
@prashantmital prashantmital force-pushed the PYTHON-2371/new-fle-keystores branch from 347d425 to 30b2fa4 Compare October 29, 2020 03:29
ShaneHarvey
ShaneHarvey requested changes Oct 29, 2020
View reviewed changes
ShaneHarvey
ShaneHarvey approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prashantmital prashantmital merged commit e49c418 into mongodb:master Oct 29, 2020
@prashantmital prashantmital deleted the PYTHON-2371/new-fle-keystores branch October 29, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantmital @ShaneHarvey