Skip to content

PYTHON-1631 Automate release wheels for Windows and manylinux #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2020

Conversation

ShaneHarvey
Copy link
Member

No description provided.

git_tag_only: false # TODO: change to true once POC is done
[2020/07/23 00:24:00.482] + docker run --rm -v /data/mci/cd100cec6341abda533450fb3f2fab99/src:/pymongo quay.io/pypa/manylinux2014_aarch64 /pymongo/.evergreen/build-wheels.sh
[2020/07/23 00:24:01.186] standard_init_linux.go:211: exec user process caused "exec format error"
@@ -2519,6 +2555,13 @@ buildvariants:
- name: "aws-auth-test-4.4"
- name: "aws-auth-test-latest"

- matrix_name: "Release"
matrix_spec:
platform: [ubuntu-16.04, windows-64-vsMulti-small]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not Ubuntu 18? 16 goes EOL in April.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 18. They both have Docker so either one works.

@@ -0,0 +1,12 @@
#!/bin/bash -ex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding this now since we can't actually do it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still use it to build macos wheels manually.

docker version

# 2020-03-20-2fda31c Was the last release to include Python 3.4.
images=(quay.io/pypa/manylinux1_x86_64:2020-03-20-2fda31c \
Copy link
Member

@behackett behackett Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all versions other than 3.4 get built twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. They get built first with these old images and then rebuilt and overwritten with the latest manylinux1_x86_64/manylinux1_i686 images.

Copy link
Contributor

@prashantmital prashantmital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming build-wheels.sh to something that makes it clear that the script is really only relevant for dockerized Linux builds.

Looks really clean. Great work!

@ShaneHarvey ShaneHarvey merged commit c92150d into mongodb:master Jul 28, 2020
@ShaneHarvey ShaneHarvey deleted the PYTHON-1631 branch July 28, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants