Skip to content

PYTHON-5109 - Convert test.test_versioned_api to async #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from sleepyStick February 3, 2025 19:28
@@ -61,7 +51,7 @@ def test_server_api_validation(self):
with self.assertRaises(TypeError):
ServerApi("1", deprecation_errors="not-a-bool") # type: ignore[arg-type]
with self.assertRaises(TypeError):
MongoClient(server_api="not-a-ServerApi")
AsyncMongoClient(server_api="not-a-ServerApi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, forgot to undo this change when I split the unit and integration tests apart.

@NoahStapp NoahStapp requested a review from sleepyStick February 3, 2025 20:11
sleepyStick
sleepyStick previously approved these changes Feb 3, 2025
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@NoahStapp NoahStapp merged commit f344eb7 into mongodb:master Feb 5, 2025
35 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants