Skip to content

PYTHON-5107 - Convert test.test_streaming_protocol to async #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from sleepyStick February 3, 2025 15:04
@@ -78,7 +79,7 @@ def marked_unknown():
def rediscovered():
return len(listener.matching(_discovered_node)) >= 1

# Topology events are published asynchronously
# Topology events are published synchronously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, changed to not get caught by the synchro script.

@NoahStapp NoahStapp requested a review from sleepyStick February 3, 2025 20:07
sleepyStick
sleepyStick previously approved these changes Feb 3, 2025
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NoahStapp NoahStapp merged commit 02d6cc9 into mongodb:master Feb 5, 2025
35 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants