PYTHON-5115 Type validation errors should include the invalid type name #2085
Conversation
tejaschauhan36912
commented
Jan 28, 2025
tejaschauhan36912
commented
- Enhanced error message with more details for better debugging experience.
There was a problem hiding this comment.
Looks like the changes in this file (and some other asynchronous files) aren't reflected in sync, did you run prepre-commit run --all-files before committing?
There was a problem hiding this comment.
yes, I did but not getting any changes in sync files.
$ pre-commit run --all-files
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check toml...............................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
forbid new submodules................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
synchro..................................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
blacken-docs.............................................................Passed
rst code is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst inline code next to normal text..................................Passed
rstcheck.................................................................Passed
Validate GitHub Workflows................................................Passed
Validate GitHub Actions..............................(no files to check)Skipped
Validate Dependabot Config (v2)..........................................Passed
codespell................................................................Passed
executable-shell.........................................................Passed
There was a problem hiding this comment.
I have invited you to access my forked repo, clone it, check out the detailed-error-msg branch, run pre-commit in your environment and if it works then push the changes here.
There was a problem hiding this comment.
Hi @sleepyStick!
Please help to merge this PR.
Does the tools\synchro.py migrate error message changes?
There was a problem hiding this comment.
Sorry just seeing this, let me try this now :)
There was a problem hiding this comment.
I just ran pre-commit on my local copy of your branch and synchro looked like this (which is what i expected)
synchro..................................................................Failed
- hook id: synchro
- files were modified by this hook
just pushed those changes :)
There was a problem hiding this comment.
Sorry just seeing this, let me try this now :)
Hey, thanks for listening, you are a gem!
There was a problem hiding this comment.
I just ran pre-commit on my local copy of your branch and synchro looked like this (which is what i expected)
synchro..................................................................Failed - hook id: synchro - files were modified by this hookjust pushed those changes :)
Oh, then something is wrong with my setup.
|
@sleepyStick please merge this PR if we don't have any changes to add. |
There was a problem hiding this comment.
@sleepyStick do you mind opening a Jira ticket to describe this change and linking it in the PR title + merge commit?
pymongo/asynchronous/auth.py
Outdated
| @@ -161,7 +161,7 @@ def _password_digest(username: str, password: str) -> str: | |||
| if len(password) == 0: | |||
| raise ValueError("password can't be empty") | |||
| if not isinstance(username, str): | |||
| raise TypeError("username must be an instance of str") | |||
| raise TypeError(f"username must be an instance of str, not {type(username)}.") | |||
There was a problem hiding this comment.
It is customary to omit the period in these error messages. Do you mind changing these from not {type(<>)}." to not {type(<>)}"?
There was a problem hiding this comment.
Actually is seems there are examples of both in our codebase so either way is fine with me though I still have a slight preference for omitting it. @sleepyStick I'll defer to your opinion.
There was a problem hiding this comment.
I think I like omitting it as well, lemme clean it up and then I'll merge it :)
Sorry, I kinda thought you could merge and I wanted you to have the honors! |
created PYTHON-5115 |
sleepyStick
changed the title
