Skip to content

Remove redundant branch in GridFS #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

ShaneHarvey
Copy link
Member

minor code cleanup

Jibola
Jibola previously approved these changes Feb 11, 2025
@ShaneHarvey ShaneHarvey requested a review from Jibola February 26, 2025 21:22
@ShaneHarvey
Copy link
Member Author

@Jibola I needed to update this since your last review to fix the type checking failures. It's ready for another look now.

Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. funny how removing type ignores solved your issue.

@ShaneHarvey ShaneHarvey merged commit e52965e into mongodb:master Feb 27, 2025
46 of 51 checks passed
@ShaneHarvey ShaneHarvey deleted the remove-redundant-gridfs.read branch March 4, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants