PYTHON-4975 Use justfile as the task runner #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zizmor failure is unrelated: zizmorcore/zizmor#431 |
|
@NoahStapp this is ready for review |
NoahStapp
requested changes
Jan 17, 2025
pymongo/pyopenssl_context.py
Outdated
| @@ -277,7 +277,7 @@ def __get_options(self) -> None: | |||
| # Calling set_options adds the option to the existing bitmask and | |||
| # returns the new bitmask. | |||
| # https://www.pyopenssl.org/en/stable/api/ssl.html#OpenSSL.SSL.Context.set_options | |||
| return self._ctx.set_options(0) | |||
There was a problem hiding this comment.
Accidental regression? This incorrect type hint is fixed in master.
| @@ -13,6 +13,32 @@ else | |||
| SUDO="sudo" | |||
| fi | |||
|
|
|||
| # Install just. | |||
| if [ "${CI:-}" == "true" ]; then | |||
There was a problem hiding this comment.
Is CI set somewhere by drivers-evergreen-tools on some platforms?
There was a problem hiding this comment.
It is set on Evergreen jobs only. I'll add a comment.
Co-authored-by: Noah Stapp <noah@noahstapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a cross-section of tasks here: https://spruce.mongodb.com/version/67830641207aee000703f428/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC.
The justfile itself will get a lot cleaner once we switch to uv. We'll be able to install
justanduvin the system setup, and then useuv runinstead of all these hard-coded paths.