Skip to content

PYTHON-4827 - Fix dnspython typechecking failures #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

PYTHON-4827 - Fix dnspython typechecking failures #1903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c167e5
PYTHON-4827 - Fix dnspython typechecking failures
NoahStapp Oct 8, 2024
d79ad38
Merge branch 'master' into PYTHON-4827
blink1073 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pymongo/srv_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def get_options(self) -> Optional[str]:
raise ConfigurationError(str(exc)) from None
if len(results) > 1:
raise ConfigurationError("Only one TXT record is supported")
return (b"&".join([b"".join(res.strings) for res in results])).decode("utf-8")
return (b"&".join([b"".join(res.strings) for res in results])).decode("utf-8") # type: ignore[attr-defined]

def _resolve_uri(self, encapsulate_errors: bool) -> resolver.Answer:
try:
Expand All @@ -121,7 +121,8 @@ def _get_srv_response_and_hosts(

# Construct address tuples
nodes = [
(maybe_decode(res.target.to_text(omit_final_dot=True)), res.port) for res in results
(maybe_decode(res.target.to_text(omit_final_dot=True)), res.port) # type: ignore[attr-defined]
for res in results
]

# Validate hosts
Expand Down
Loading