Skip to content

PYTHON-4796 Update type checkers and handle with_options typing #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2024
Merged

PYTHON-4796 Update type checkers and handle with_options typing #1880

merged 3 commits into from
Sep 30, 2024

Conversation

blink1073
Copy link
Member

No description provided.

caseyclements
caseyclements approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I didn't catch the conversation in the meeting, but this pretty sweet. It comes with caveats?

@blink1073
Copy link
Member Author

blink1073 commented Sep 30, 2024 •
edited
Loading

It comes with caveats?

I split this off from PYTHON-3992 and marked that as 5.0, because that change had some unexpected affects.

@blink1073 blink1073 merged commit 3ef565f into mongodb:master Sep 30, 2024
33 checks passed
@blink1073 blink1073 deleted the PYTHON-3992 branch September 30, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyclements caseyclements caseyclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @caseyclements