PYTHON-4537 - Use selector asyncio loop on windows tests #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Jul 25, 2024
| # has issues with sharing sockets across loops (https://github.com/python/cpython/issues/122240) | ||
| # We explicitly use a different loop implementation here to prevent that issue | ||
| if not _IS_SYNC and sys.platform == "win32": | ||
| asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) # type: ignore[attr-defined] |
There was a problem hiding this comment.
We can't call asyncio.set_event_loop_policy since that has global side effects. Instead we need to explicitly create our on loop, possibly only when the default would be the ProactorEventLoop.
ShaneHarvey
requested changes
Jul 25, 2024
| and sys.platform == "win32" | ||
| and asyncio.get_event_loop_policy() == asyncio.WindowsProactorEventLoopPolicy | ||
| ): | ||
| loop = asyncio.WindowsSelectorEventLoopPolicy().new_event_loop() # type: ignore[attr-defined] |
There was a problem hiding this comment.
How about we just always use WindowsSelectorEventLoopPolicy on windows for now. I'm worried the WindowsProactorEventLoopPolicy check won't work for custom policies that use the proactor loop.
There was a problem hiding this comment.
Let's also call asyncio.SelectorEventLoop() directly.
ShaneHarvey
reviewed
Jul 25, 2024
| # The default asyncio loop implementation on Windows | ||
| # has issues with sharing sockets across loops (https://github.com/python/cpython/issues/122240) | ||
| # We explicitly use a different loop implementation here to prevent that issue | ||
| if not _IS_SYNC and sys.platform == "win32": |
There was a problem hiding this comment.
We can remove not _IS_SYNC here.
ShaneHarvey
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.