-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4565 - Use pytest markers for test suite configuration #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can't reproduce the typechecking failures locally, could it be a toolchain issue? |
PyOpenSSL just had a release, you might be using an older version locally. |
Just updated to the newest version, still no issue locally. |
It isn't the toolchain, because it is happening on GitHub. |
Note it also occurs in #1742 |
Ah, they just recently added type hints to the library itself, I assume we were using types-pyopenssl before. Can you open a ticket? https://github.com/pyca/pyopenssl/blob/main/src/OpenSSL/py.typed |
Did we explicitly include |
It gets pulled in by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.