PYTHON-4449 Ensure resume options aren't combined during automatic retry #1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Quoting from the spec: "startAtOperationTime, resumeAfter, and startAfter are all mutually exclusive; if any two are set, the server will return an error. Drivers MUST NOT throw a custom error, and MUST defer to the server error." |
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://jira.mongodb.org/browse/JAVA-2987 and https://jira.mongodb.org/browse/NODE-2022
If
start_at_operation_timewas supplied towatchand the first event is an invalidate, or connection timeout, or anything that triggers an automatic retry - apymongo.errors.OperationFailureis thrown with the message "Only one type of resume option is allowed, but multiple were found"The solution from those other issues have been mimicked in this PR
Jira link: https://jira.mongodb.org/browse/PYTHON-4449