PYTHON-3467 OIDC: Automatic token acquisition for Azure Identity Provider #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
reviewed
Feb 1, 2024
| set -o errexit | ||
| ${PREPARE_SHELL} | ||
| cd src | ||
| git add . |
There was a problem hiding this comment.
Humor me if this is a silly question. Is the ${PREPARE_SHELL} command responsible for adding in the new files for the commit?
There was a problem hiding this comment.
No, it sets up common env variables.
Jibola
requested changes
Feb 1, 2024
There was a problem hiding this comment.
This PR is great. I really appreciate all of the testing comments which made things extremely easy to follow/keep track of.
I've placed primarily NITs as feedback and some grammar fixes. Requested Changes just to get clarifications.
Other than that, LGTM. Pending the responses, can give approval stamp.
Jibola
approved these changes
Feb 1, 2024
Co-authored-by: Jib <Jibzade@gmail.com>
Co-authored-by: Jib <Jibzade@gmail.com>
Co-authored-by: Jib <Jibzade@gmail.com>
Co-authored-by: Jib <Jibzade@gmail.com>
Co-authored-by: Jib <Jibzade@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative continuation of #1401, based on #1209.
Depends on mongodb-labs/drivers-evergreen-tools#376.