-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-950: Run legacy CSFLE tests on serverless #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPLIB-950: Run legacy CSFLE tests on serverless #988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, we don't run serverless tests for PR builds. Please schedule an Evergreen patch build that includes the serverless task(s) and attach it to this PR so we can confirm that all works before merging.
--out $MONGODB_BINARIES \ | ||
--strip-path-components 2 | ||
|
||
# Download the crypt_shared dynamic library for the current platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this is handled by run-orchestration.sh in drivers-evergreen-tools for non-serverless tests. That appears to be exactly what DRIVERS-2459 is meant to address.
IMO, this should have been addressed as a prerequisite for DRIVERS-2400 before spawning language tickets and inviting drivers to sort this out on their own.
@@ -4,7 +4,8 @@ | |||
"minServerVersion": "6.0.0", | |||
"topology": [ | |||
"replicaset", | |||
"sharded" | |||
"sharded", | |||
"load-balanced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the commits in this PR indicate the sync target for spec tests. According to DRIVERS-2400 this is mongodb/specifications@59a07b7. Please add that and ensure it ends up in the final squash message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Added to the last commit and will make sure it ends in the squash message.
Sorry for not mentioning that above. I scheduled a patch build already: https://evergreen.mongodb.com/build/mongo_php_library_serverless__php_edge_versions~latest_stable_driver_versions~latest_stable_os~debian11_patch_8a327525dbb4a2a9bceac62bfc027e88309db756_633d6772a4cf4706e978aee3_22_10_05_11_16_03?redirect_spruce_users=true Note that scheduling an additional task in a PR build has the advantage of making the required evergreen check fail if the additional task fails, which in turn prevents a merge of the PR. Only downside is that this has to be done every time after pushing changes, as that will trigger a new evergreen patch build discarding the previously selected tasks. |
1083fe4
to
8c0111c
Compare
PHPLIB-950
Includes fixes required to get CSFLE running on Serverless in general:
The download logic was shamelessly copied from the GO driver, as this isn't available through drivers-evergreen-tools. I've created DRIVERS-2459 to track this and will take a look when possible.