PHPLIB-987: Add more examples #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 28, 2022
jmikola
approved these changes
Sep 30, 2022
| @@ -71,7 +70,7 @@ function toJSON(object $document): string | |||
| ] | |||
| ); | |||
|
|
|||
| $cursor = $collection->find([], ['batchSize' => 2]); | |||
| $cursor = $collection->find([]); | |||
There was a problem hiding this comment.
FWIW, Collection::find() can be called without arguments as $filter defaults to an empty array. This technically violates the CRUD spec but we snuck that past the goalie long ago. Up to you if you'd like to keep this as-is or change to find().
Likewise in with_transaction.php.
alcaeus
force-pushed
the
phplib-987-examples
branch
from
f1913ea to
28efb21
Compare
alcaeus
force-pushed
the
phplib-987-examples
branch
from
28efb21 to
fb314f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-987
This PR adds more examples for every-day use of the PHP library. New examples:
with_transactionhelperMongoDB\BSON\PersistabletypeMapandMongoDB\BSON\UnserializableThe first commit in the PR fixes an issue where running the example code from outside of the examples directory causes fatal errors.