PHPLIB-678: Remove obsolete handling of options arg for insertMany #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Changes LGTM, but note that there are still a few Evergreen CI failures. This appears to be because this PR's branch doesn't include the synced CSFLE tests from 86da93b (re: #967). That was merged five days ago, and this PR was only opened yesterday, so I would have expected the change to be in place.
I expect your local master branch hasn't been updated since before that PR was merged. Please keep this in mind for future PRs so we can cut down on unnecessary CI failures.
levon80999
added a commit
to levon80999/mongo-php-library
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-678