PHPLIB-912, PHPLIB-914, PHPLIB-924: Sync change stream spec tests #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Aug 29, 2022
| @@ -0,0 +1,251 @@ | |||
| { | |||
| "description": "disambiguatedPaths", | |||
There was a problem hiding this comment.
@levon80999: It wasn't my intention to steal your assigned tickets, but the spec changes for PHPLIB-914 and PHPLIB-924 were included when I synced to the commit for PHPLIB-912.
|
Note: the two CI test failures appear to be related to PHPLIB-930. |
levon80999
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-912
https://jira.mongodb.org/browse/PHPLIB-914
https://jira.mongodb.org/browse/PHPLIB-924
This can serve as a POC for mongodb/specifications#1293. It also includes two other PHPLIB tickets for previously updated change stream spec tests, neither of which required driver changes.
Tested locally using server 6.1.0-alpha-2444-gfb80d4b, which I grabbed from download-mongodb.sh.