PHPLIB-869: Support viewOn and pipeline options in createCollection helper #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
May 24, 2022
docs/includes/apiargs-MongoDBDatabase-method-createCollection-option.yaml
Outdated
Show resolved
Hide resolved
docs/includes/apiargs-MongoDBDatabase-method-createCollection-option.yaml
Outdated
Show resolved
Hide resolved
|
|
||
| $expectedIndex += 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
This was copied from Aggregate.php, but the exception messages were not updated to reflect that pipeline is an option and not a constructor parameter. Please apply the suggestions above.
I also created PHPLIB-881 to refactor this to share common code with other instances of pipeline validation.
…option.yaml Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
…option.yaml Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
jmikola
reviewed
May 24, 2022
docs/includes/apiargs-MongoDBDatabase-method-createCollection-option.yaml
Show resolved
Hide resolved
docs/includes/apiargs-MongoDBDatabase-method-createCollection-option.yaml
Show resolved
Hide resolved
…option.yaml Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
…option.yaml Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
jmikola
reviewed
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-869