PHPLIB-682: Add test for Database::dropCollection() #847
Conversation
|
|
||
| $commandResult = $this->database->dropCollection($this->getCollectionName()); | ||
| $this->assertCommandSucceeded($commandResult); | ||
| $this->assertCollectionCount($this->getNamespace(), 0); |
There was a problem hiding this comment.
Once #840 is merged, please change this use the assertCollectionDoesNotExist() method that was moved to the base class. Asserting that no collections exist in the namespace is not reliable. This is why DropCollectionFunctionalTest originally had its own assertCollectionDoesNotExist method.
I assume you might have copied this from testDrop. That case is different as we're dropping the entire database and should expect no collections to exist within it after the fact.
There was a problem hiding this comment.
Ah my bad, I will fix that again
There was a problem hiding this comment.
I noticed that assertCollectionCount() is still being used in the testDrop() of CollectionFunctionalTest.php. Should I create a new ticket to fix that?
There was a problem hiding this comment.
Ah, I didn't realize it was also being used there (dates back to c520df8#diff-1ab446f85499e8289fa4a8373d33f1aaadc5ffc63f5561dd6335342ef000b4d2R19). I originally assumed this was lifted from DatabaseFunctionalTest::testDrop.
Please do change CollectionFunctionalTest::testDrop to use assertCollectionCount.
https://jira.mongodb.org/browse/PHPLIB-682