PHPLIB-434: Add note about performance of countDocuments #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
approved these changes
Apr 7, 2020
| @@ -52,6 +52,14 @@ obtain the result. If a ``filter`` parameter is given, this is converted into | |||
| a ``$match`` pipeline operator. Optional ``$skip`` and ``$limit`` stages are | |||
| added between ``$match`` and ``group`` if present in the options. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| This method counts documents on the server side. To obtain the total number | |||
There was a problem hiding this comment.
I think it would be clearer to say "To obtain an approximate total number of documents ...". When I read the current language, I first see "the total number" which to me is the exact number, and when I read the rest of the sentence I mentally go back and revise "the total number" to become "an estimated number".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-434