PHPLIB-537: Use whitelist to check if a change stream is resumable #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
reviewed
Mar 24, 2020
src/ChangeStream.php
Outdated
| } | ||
|
|
||
| if (in_array($exception->getCode(), self::$nonResumableErrorCodes)) { | ||
| if ($exception->hasErrorLabel('NonResumableChangeStreamError')) { |
There was a problem hiding this comment.
I do not see anything in the spec about "NonResumableChangeStreamError" label, is this something PHP POCed?
There was a problem hiding this comment.
Based on mongodb/specifications@f93d781#diff-875f237661962b4ca9b2e58d97449831L49 and the conversation in driver-devs I am under the impression that this error label should no longer be consulted, what do you think @alcaeus ?
There was a problem hiding this comment.
Yes, that is correct. I've removed the label.
p-mongo
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-537