Skip to content

PHPLIB-1378 Replace example printfs with a callable #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

paulinevos
Copy link
Contributor

@paulinevos paulinevos commented Jun 4, 2025

PHPLIB-1378

To make it easier for users to work off the examples without having to replace all the print statements

@paulinevos paulinevos requested a review from a team as a code owner June 4, 2025 13:55
@paulinevos paulinevos requested a review from alcaeus June 4, 2025 13:55
@paulinevos paulinevos changed the title Replace example printfs with a callable PHPLIB-1378 Replace example printfs with a callable Jun 4, 2025
@paulinevos paulinevos force-pushed the 1378_replace-printf-calls branch 2 times, most recently from f9cf53a to ca244cb Compare June 4, 2025 15:07
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing tests were fixed in #1712, so rebasing on top of v2.x should fix the broken build.

To make it easier for users to work off the examples without having to
replace all the print statements
@paulinevos paulinevos force-pushed the 1378_replace-printf-calls branch from ca244cb to cc7979f Compare June 5, 2025 08:57
@paulinevos paulinevos enabled auto-merge (squash) June 5, 2025 09:01
@paulinevos paulinevos merged commit 2adc14f into mongodb:v2.x Jun 5, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants