Skip to content

Merge v1.x into v2.x #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,5 @@ runs:
- name: Install dependencies with Composer
uses: ramsey/composer-install@3.0.0
with:
# Revert when psalm supports PHP 8.4
# composer-options: "--no-suggest"
composer-options: "--no-suggest ${{ inputs.php-version == '8.4' && '--ignore-platform-req=php+' || '' }}"
composer-options: "--no-suggest"
working-directory: "${{ inputs.working-directory }}"
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"phpunit/phpunit": "^10.5.35",
"rector/rector": "^1.2",
"squizlabs/php_codesniffer": "^3.7",
"vimeo/psalm": "^5.13"
"vimeo/psalm": "^6.5"
},
"replace": {
"mongodb/builder": "*"
Expand Down
12 changes: 1 addition & 11 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
<files psalm-version="6.5.1@3f17a6b24a2dbe543e21408c2b19108cf6a355ef">
<file src="examples/atlas_search.php">
<MixedArgument>
<code><![CDATA[$document['name']]]></code>
Expand Down Expand Up @@ -696,9 +696,6 @@
<code><![CDATA[$options['writeConcern']]]></code>
<code><![CDATA[$value]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array|object|null]]></code>
</MixedInferredReturnType>
<MixedMethodCall>
<code><![CDATA[decode]]></code>
<code><![CDATA[isInTransaction]]></code>
Expand Down Expand Up @@ -817,9 +814,6 @@
<MixedAssignment>
<code><![CDATA[$this->postBatchResumeToken]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array|object|null]]></code>
</MixedInferredReturnType>
<MixedPropertyFetch>
<code><![CDATA[$reply->cursor->firstBatch]]></code>
<code><![CDATA[$reply->cursor->postBatchResumeToken]]></code>
Expand Down Expand Up @@ -858,10 +852,6 @@
<code><![CDATA[$typeMap['fieldPaths'][$fieldPath]]]></code>
<code><![CDATA[$value]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array|object|null]]></code>
<code><![CDATA[array|object|null]]></code>
</MixedInferredReturnType>
<MixedReturnStatement>
<code><![CDATA[$collectionInfo['options']['encryptedFields'] ?? null]]></code>
<code><![CDATA[$collectionInfo['options']['encryptedFields'] ?? null]]></code>
Expand Down
5 changes: 2 additions & 3 deletions psalm.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<psalm
errorLevel="1"
errorBaseline="psalm-baseline.xml"
ignoreInternalFunctionFalseReturn="true"
ignoreInternalFunctionNullReturn="true"
resolveFromConfigFile="true"
findUnusedBaselineEntry="true"
findUnusedCode="false"
Expand All @@ -18,9 +20,6 @@
</projectFiles>

<stubs>
<file name="stubs/BSON/Document.stub.php"/>
<file name="stubs/BSON/Iterator.stub.php"/>
<file name="stubs/BSON/PackedArray.stub.php"/>
<file name="stubs/Driver/Cursor.stub.php"/>
<file name="stubs/Driver/CursorInterface.stub.php"/>
<file name="stubs/Driver/WriteResult.stub.php"/>
Expand Down
49 changes: 0 additions & 49 deletions stubs/BSON/Document.stub.php

This file was deleted.

29 changes: 0 additions & 29 deletions stubs/BSON/Iterator.stub.php

This file was deleted.

40 changes: 0 additions & 40 deletions stubs/BSON/PackedArray.stub.php

This file was deleted.

Loading