-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-1600 Accept stdClass
objects in BSONDocument
constructor
#1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/Model/BSONDocumentTest.php
Outdated
protected string $baz = 'qux'; | ||
}); | ||
$this->assertSame('bar', $document->foo); | ||
$this->assertObjectNotHasProperty('baz', $document); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially a test of ArrayObject itself. I think it'd be preferable to test bsonSerialize()
(note: jsonSerialize()
has the same implementation), so we can see what would actually get serialized to BSON.
My concern is that we should preserve the same encoding behavior as the extension, which will only encodes public properties.
See: https://3v4l.org/47VCv#v8.4.1
I think it's bit strange that the encoded names for protected and private properties still end up in output from ArrayObject::getArrayCopy()
, and are preserved when casting back to an object. It's certainly odd that the stdClass instance resulting from that cast ends up with non-public properties, but that's likely an oddity of PHP itself.
If we can get away with only accepting stdClass|array
, that might circumvent this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I followed your suggestion on allowing only array|stdClass
. That covers the request.
object
in BSONDocument
constructorstdClass
onjects in BSONDocument
constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I think you can remove two lines from the test case.
stdClass
onjects in BSONDocument
constructorstdClass
objects in BSONDocument
constructor
Fixes PHPLIB-1600
Fixes #1549
Only
stdClass
objects are allowed, because other types of objects can have private/protected properties and we don't what to define the rule for this properties (keep or skip).