DOP-4904: Remove docs/ from v1.17 #1369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Aug 12, 2024
There was a problem hiding this comment.
From this version, you need to remove <file>docs/examples</file> from phpcs.xml
mongo-php-library/phpcs.xml.dist
Line 14 in 28aabbe
Is there a plan to enable style checks in the new doc repository?
GromNaN
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Some tests need to be moved as the this files are removed.
mongo-php-library/tests/ExamplesTest.php
Line 302 in 28aabbe
Failing test:
https://github.com/mongodb/mongo-php-library/actions/runs/10343254255/job/28627151546?pr=1369#step:9:224
|
Closing as we won't be removing docs from old branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to mongodb/docs-php-library#97.