PHPLIB-1279: Revise driver/extension terminology #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer "extension" over "driver" when referring to ext-mongodb specifically. Also removes mention of Int64 having a private constructor.
bisht2050
approved these changes
Jun 5, 2024
| @@ -67,10 +67,9 @@ MongoDB\\Exception\\UnexpectedValueException | |||
| This exception is thrown when a command response from the server is | |||
| malformed or not what the library expected. This exception means that an | |||
| assertion in some operation, which abstracts a database command, has failed. | |||
| It may indicate a corrupted BSON response or bug in the server, driver, or | |||
| library. | |||
| It may indicate a corrupted BSON response or bug in the server or driver. | |||
There was a problem hiding this comment.
Is driver referring to the extension, library or extension+library in this line?
There was a problem hiding this comment.
Any remaining references to "driver" should be taken to mean extension and/or library, where there is no need to differentiate.
alcaeus
approved these changes
Jun 5, 2024
|
We can ignore rector in this branch. |
Merged
jmikola
added a commit
that referenced
this pull request
Jun 6, 2024
* Merge v1.16 into v1.17 (#1327) * PHPLIB-1279: Revise driver/extension terminology (#1335) Prefer "extension" over "driver" when referring to ext-mongodb specifically. Also removes mention of Int64 having a private constructor. * PHPLIB-1466: Remove obsolete "Type Map Limitations" --------- Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1279
https://jira.mongodb.org/browse/PHPLIB-1466
This updates references where we're discussing something specific to the extension. I've left "driver" in place for more general discussion about the PHP driver or for special topics such as "driver options" on Manager and Client objects.
I've targeted v1.17 for this as it's the oldest branch that doesn't conflict. I think it'd be reasonable to drop v1.16 entirely from https://www.mongodb.com/docs/php-library/current/ since we've had new releases following the original Giza -> Snooty port.