PHPLIB-1313 Ensure the GridFS stream is saved when the script ends #1197
Conversation
| /* This destructor is a workaround for PHP trying to use the stream well | ||
| * after all objects have been destructed. This can cause autoloading | ||
| * issues and possibly segmentation faults during PHP shutdown. */ | ||
| $this->stream = null; |
There was a problem hiding this comment.
I can remove this line introduced by PHPLIB-345 because even if PHP tries to close the stream again, this is no-op.
There was a problem hiding this comment.
Note that the new test reproduces also the issue described in PHPLIB-345.
There was a problem hiding this comment.
I'd have to go back and check, but PHP may also have fixed this issue by shutting down streams earlier in the shutdown process. Either way, manually closing the stream definitely fixes the write issue, but if we want to be absolutely sure we can also reset the stream property as was done previously to ensure the issue does not re-appear.
There was a problem hiding this comment.
I was able to reproduce the "autoloading" issue by removing the __destruct() function. So I don't see what would have changed in PHP core for this.
There was a problem hiding this comment.
Ah, I see. Since you've confirmed that the current code works around the issue, no objections to merging this as is 👍
|
|
* master: PHPLIB-1323 Implement `unlink` for GridFS stream wrapper (mongodb#1206) PHPLIB-1330: Sync tests for failCommand errorLabels reqs (mongodb#1214) PHPLIB-1246: Test PHP 8.3 on Evergreen (mongodb#1213) PHPLIB-1324 Implement `rename` for GridFS stream wrapper (mongodb#1207) PHPLIB-1248 Add examples on GridFS (mongodb#1196) Deprecate setting GridFS disableMD5 to false explicitly (mongodb#1205) PHPLIB-1326: Use more permissive top-level runOnRequirements (mongodb#1210) PHPLIB-1206 Add bucket alises for context resolver using GridFS StreamWrapper (mongodb#1138) Bump actions/upload-artifact from 3 to 4 (mongodb#1208) PHPLIB-1275: Replace apiargs usage in docs with extracts (mongodb#1203) Fix title formatting in Client::removeSubscriber() docs (mongodb#1204) PHPLIB-1304: Pull mongohouse image from ECR repo (mongodb#1202) Fix evergreen failures (mongodb#1200) Enable workflows to run for GitHub Merge Queue (mongodb#1199) PHPLIB-1313 Ensure the GridFS stream is saved when the script ends (mongodb#1197) PHPLIB-1309 Add addSubscriber/removeSubscriber to Client class to ease configuration (mongodb#1195) Master is now 1.18-dev
Fix PHPLIB-1313
By forcing the writable stream to be properly closed, we ensure the file is sent to the server when the process stops.