PHP 7.3 polyfill is not necessary because PHP 7.4 is required #1167
Conversation
| "type": "path", | ||
| "url": "../", | ||
| "symlink": true | ||
| "name": "mongodb/mongodb-benchmark", |
| "replace": { | ||
| "symfony/polyfill-php80": "*", | ||
| "symfony/polyfill-php81": "*" | ||
| }, |
There was a problem hiding this comment.
The benchmark sub-project requires PHP 8.1, I disable the installation of this polyfills.
There was a problem hiding this comment.
Is this the preferred method to avoid installing polyfills that are indirect dependencies? I suppose in an ideal world the polyfill packages would have some way to note that they're redundant for newer PHP versions (an inverse of requires), but there's no composer.json syntax for that.
There was a problem hiding this comment.
Strictly speaking, it's not necessary to prevent installing the polyfills. The polyfill itself checks if the function exists and doesn't register itself if it does.
That said, I'm fine including these directives here until we can use PHP 8.1.
| "replace": { | ||
| "symfony/polyfill-php80": "*", | ||
| "symfony/polyfill-php81": "*" | ||
| }, |
There was a problem hiding this comment.
Is this the preferred method to avoid installing polyfills that are indirect dependencies? I suppose in an ideal world the polyfill packages would have some way to note that they're redundant for newer PHP versions (an inverse of requires), but there's no composer.json syntax for that.
I think it has been forgotten in #1128
get_debug_typefrom PHP 8.0 polyfill is usedarray_is_listfrom PHP 8.1 polyfill is usedThe benchmark sub-project requires PHP 8.1, I disable the installation of this polyfills.