Add test on UnifiedTestRunner::setEntityMapObserver()
#1129
Conversation
GromNaN
changed the title
$entityMapObserver in tests
| * | ||
| * @param callable(EntityMap):void $entityMapObserver | ||
| */ | ||
| public function setEntityMapObserver(callable $entityMapObserver): void |
There was a problem hiding this comment.
This is called from the PHP workload executor in the Atlas testing project (see: workload-executor.php).
If you'd like to repurpose this PR you can add a link to the https://github.com/mongodb-labs/drivers-atlas-testing/ repository.
There was a problem hiding this comment.
Indeed, it was written in the comment above.
I updated the PR to add link and test this feature.
GromNaN
force-pushed
the
entityMapObserver
branch
from
35349eb to
6829582
Compare
GromNaN
changed the title
$entityMapObserver in testsUnifiedTestRunner::setEntityMapObserver()
| { | ||
| public function testEntityMapObserver(): void | ||
| { | ||
| $test = UnifiedTestCase::fromFile(__DIR__ . '/crud/find.json'); |
There was a problem hiding this comment.
For the sake of completeness, this test might start failing if the crud tests change significantly. Creating a separate test would be safer, but for the sake of getting this method tested (and thus used) this suffices.
There was a problem hiding this comment.
Indeed, I'll create a file specifically test the tester.
GromNaN
force-pushed
the
entityMapObserver
branch
from
6829582 to
0b29bcf
Compare
UnifiedTestRunner::setEntityMapObserver()is used in `drivers-atlas-testing.