PHPLIB-1152: replace private static with private const
#1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception Client::$version which is initialized dynamically
jmikola
reviewed
Jun 9, 2023
| @@ -42,15 +42,11 @@ class ChangeStream implements Iterator | |||
| { | |||
| /** | |||
| * @deprecated 1.4 | |||
| * @todo Remove this in 2.0 (see: PHPLIB-360) | |||
| * @todo make this constant private in 2.0 (see: PHPLIB-360) | |||
There was a problem hiding this comment.
Ah, I understand why this was changed. You couldn't convert private static $cursorNotFound to a private const because of this existing definition.
I just revised PHPLIB-360 accordingly to capture this change.
jmikola
approved these changes
Jun 9, 2023
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1152
Client::$versionis the only one left because it is initialised from composer install.