Skip to content

Remove "build/" from autotools scripts path #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2018

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 16, 2018

GitHub's file finder filters out "build/" directories, among others, which can make it difficult to quickly access these files. Also, the "build/" directory doesn't provide much value here, since it only contains "autotools/".

To quote an exchange I had with GitHub support:

I've noticed that the file finder (activated using T) has problems searching up certain files in repositories. The only connection I can make is that these files include "build" in their path (relative to the repository root).

Is this intentional?

Response:

Yes, we intentionally excludes files in certain paths, including build, for performance reasons.

@jmikola jmikola requested a review from derickr May 16, 2018 13:41
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GitHub's file finder filters out "build/" directories, among others, which can make it difficult to quickly access these files. Also, the "build/" directory doesn't provide much value here, since it only contains "autotools/".
@jmikola jmikola force-pushed the move-build-scripts branch from d332307 to 4d9dd87 Compare May 16, 2018 15:03
@jmikola jmikola merged commit 4d9dd87 into mongodb:master May 16, 2018
jmikola added a commit that referenced this pull request May 16, 2018
@jmikola jmikola deleted the move-build-scripts branch May 16, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants