PHPC-1145: Fix development build warnings for numeric type conversions #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Mar 26, 2018
| @@ -41,7 +41,7 @@ static PHP_METHOD(CommandException, getResultDocument) | |||
| #if PHP_VERSION_ID >= 70000 | |||
| resultdocument = zend_read_property(php_phongo_commandexception_ce, getThis(), ZEND_STRL("resultDocument"), 0, &rv TSRMLS_CC); | |||
| #else | |||
| resultdocument = zend_read_property(php_phongo_commandexception_ce, getThis(), ZEND_STRL("resultDocument"), 0 TSRMLS_CC); | |||
| resultdocument = zend_read_property(php_phongo_commandexception_ce, getThis(), ZEND_STRL("resultDocument"), 0 TSRMLS_CC); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Sigh. Clang-format does other weird things, and they didn't reply to my issue(s) about it at all.
For now, doing the manual git checkout -- dance seems necessary.
jmikola
requested changes
Mar 26, 2018
| @@ -96,7 +96,7 @@ PHP_METHOD(CommandFailedEvent, getOperationId) | |||
| return; | |||
| } | |||
|
|
|||
| sprintf(int_as_string, "%" PHONGO_LONG_FORMAT, intern->operation_id); | |||
| sprintf(int_as_string, "%" PRId64, intern->operation_id); | |||
There was a problem hiding this comment.
IIRC, operation_id and request_id are unsigned 64-bit integers. These should use PRIu64 instead of PRId64.
| @@ -98,7 +98,7 @@ PHP_METHOD(CommandStartedEvent, getOperationId) | |||
| return; | |||
| } | |||
|
|
|||
| sprintf(int_as_string, "%" PHONGO_LONG_FORMAT, intern->operation_id); | |||
| sprintf(int_as_string, "%" PRId64, intern->operation_id); | |||
There was a problem hiding this comment.
PRIu64 in this file for operation_id and request_id.
| @@ -75,7 +75,7 @@ PHP_METHOD(CommandSucceededEvent, getOperationId) | |||
| return; | |||
| } | |||
|
|
|||
| sprintf(int_as_string, "%" PHONGO_LONG_FORMAT, intern->operation_id); | |||
| sprintf(int_as_string, "%" PRId64, intern->operation_id); | |||
There was a problem hiding this comment.
PRIu64 in this file for operation_id and request_id.
jmikola
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1145